Re: Update to orinoco driver (2.4)

[David Gibson]

On Sat, Apr 26, 2003 at 06:22:40AM +0100, Christoph Hellwig wrote:
> On Sat, Apr 26, 2003 at 10:30:18AM +1000, David Gibson wrote:
> > On Fri, Apr 25, 2003 at 03:37:06PM +0100, Christoph Hellwig wrote:
> > > > +static void __exit exit_hermes(void)
> > > > +{
> > > > +}
> > > > +
> > > >  module_init(init_hermes);
> > > > +module_exit(exit_hermes);
> > > 
> > > Please don't add exmpty functions without a reak good reason.
> > 
> > And the real good reason would be that the module can't be unloaded
> > without an exit function.
> 
> That braindamage fortunately is not true for 2.4 and still needs
> fixing for 2.5.

Removing one empty function is insufficient cause for me to maintain
separate 2.4 and 2.5 versions.  When and if this changes in 2.5, I'll
remove the function.

-- 
David Gibson			| For every complex problem there is a
[e-mail]	| solution which is simple, neat and
				| wrong.
http://www.ozlabs.org/people/dgibson