Re: [PATCH 2.5] [TRIVIAL] Get rid of magic numbers in drivers/block/genhd.c

Christoph Hellwig (hch@lst.de)
Sun, 4 May 2003 07:55:02 +0200


On Sun, May 04, 2003 at 12:04:25AM +0200, René Scharfe wrote:
> Hi Christoph,
>
> a few days ago you cleaned up disk_name() in fs/partitions/check.c. It
> is now guaranteed to write no more than BDEVNAME_SIZE into the provided
> buffer.
>
> There are two buffers in drivers/block/genhd.c, that are used solely for
> calling disk_name(), and have a size of 64. The patch below replaces
> these magic numbers with BDEVNAME_SIZE.
>
> Additionally it corrects the comment at the top of disk_name(): The md
> driver does not call that function, the genhd driver does.

Looks fine to me.

Rusty, is the trivial patch bot still active? I haven't seen Marcelo
or Linus merging trivial patches for ages (or maybe I've missed
something?)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/