PROBLEM: linux-2.4.20 kernel bug (sound: ac97_codec.c prints garbage)

[Peter Breitenlohner]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-24830-1052124850-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi Alan,

you might not exactly be the right person for this, but at least you are
(have been) associated with sound.

PROBLEM:

1. linux-2.4.20 kernel bug (sound: ac97_codec.c prints garbage)

2. A change in drivers/sound/ac97_codec.c introduced between 2.4.18 and
2.4.20 has the consequence that ac97_codec.c prints garbage to the syslog.

3. sound

4. 2.4.20

8. This ought to be fixed as per the attached patch (or equivalent).

Some comments:
1. the format for the first snprintf is broken ("%0x4X" instead of "%4X").
2. the function should return after the first snprintf.

Possibly all this has already been noticed. If not I would appreciate it that
could be fixed for the upcoming 2.4.21.

regards
Peter Breitenlohner <[e-mail]>
--=_courier-24830-1052124850-0001-2
Content-Type: text/plain; charset=us-ascii; name="linux-2.4.20-patch"
Content-Transfer-Encoding: base64
Content-ID: <[e-mail]>
Content-Description: 
Content-Disposition: attachment; filename="linux-2.4.20-patch"

LS0tIGxpbnV4LTIuNC4yMC9kcml2ZXJzL3NvdW5kL2FjOTdfY29kZWMuYy5v
cmlnCTIwMDItMTEtMjkgMDA6NTM6MTQuMDAwMDAwMDAwICswMTAwDQorKysg
bGludXgtMi40LjIwL2RyaXZlcnMvc291bmQvYWM5N19jb2RlYy5jCTIwMDMt
MDUtMDMgMTc6NDM6MTQuMDAwMDAwMDAwICswMjAwDQpAQCAtNjY2LDExICs2
NjYsMTMgQEANCiBzdGF0aWMgY2hhciAqY29kZWNfaWQodTE2IGlkMSwgdTE2
IGlkMiwgY2hhciAqYnVmKQ0KIHsNCiAJaWYoaWQxJjB4ODA4MCkNCi0JCXNu
cHJpbnRmKGJ1ZiwgMTAsICIlMHg0WDolMHg0WCIsIGlkMSwgaWQyKTsNCi0J
YnVmWzBdID0gKGlkMSA+PiA4KTsNCi0JYnVmWzFdID0gKGlkMSAmIDB4RkYp
Ow0KLQlidWZbMl0gPSAoaWQyID4+IDgpOw0KLQlzbnByaW50ZihidWYrMywg
NywgIiVkIiwgaWQyJjB4RkYpOw0KKwkJc25wcmludGYoYnVmLCAxMCwgIiUw
NFg6JTA0WCIsIGlkMSwgaWQyKTsNCisJZWxzZSB7DQorCQlidWZbMF0gPSAo
aWQxID4+IDgpOw0KKwkJYnVmWzFdID0gKGlkMSAmIDB4RkYpOw0KKwkJYnVm
WzJdID0gKGlkMiA+PiA4KTsNCisJCXNucHJpbnRmKGJ1ZiszLCA3LCAiJWQi
LCBpZDImMHhGRik7DQorCX0NCiAJcmV0dXJuIGJ1ZjsNCiB9DQogIA0K

--=_courier-24830-1052124850-0001-2--