Re: [PATCH 2.5.68] Convert elan-104nc to remove check_region().

Bob Miller (rem@osdl.org)
Mon, 5 May 2003 10:01:18 -0700


All the request_region() calls in this driver (plus all the now removed
check_region()) calls are commented out because of conflicts with the PIC.

The release_region() call below was NOT commented out. If the driver
isn't really requsting the region it shouldn't be release it. So, I
commented it out.

On Mon, May 05, 2003 at 02:38:02PM +1000, Rusty Russell wrote:
> In message <20030502204207.GB25713@doc.pdx.osdl.net> you write:
> > Moved the request_region() call to replace check_region() and adds
> > release_region()'s in the error paths that occure before the old
> > call to request_region().
>
> > NOTE: This patch just updates comments.
>
> Actually. It doesn't.
>
> And why this:
>
> > @@ -227,14 +227,14 @@
> > }
> >
> > iounmap((void *)iomapadr);
> > - release_region(PAGE_IO,PAGE_IO_SIZE);
> > + /* release_region(PAGE_IO,PAGE_IO_SIZE); */
> > }
>
> Rusty.
> --
> Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

-- 
Bob Miller					Email: rem@osdl.org
Open Source Development Lab			Phone: 503.626.2455 Ext. 17
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/