Re: [PATCH] fix x86_64 pte_user() and floppy.h for 2.5.69

mikpe@csd.uu.se
Tue, 6 May 2003 16:26:48 +0200


Andi Kleen writes:
> On Tue, May 06, 2003 at 04:04:04PM +0200, mikpe@csd.uu.se wrote:
> > Andi,
> >
> > 2.5.69 failed to link on x86_64 due to a missing reference to pte_user().
> > I simply stole the one that i386 added in .68 -> .69.
> > There's also irqreturn_t warnings on floppy.h -- fixed also by syncing
> > with i386' floppy.h.
>
> At least the floppy.h thing is already fixed.
>
> The pte_user fix is not needed. The correct fix is to change the
> #ifdef mm/memory.c checks for. It's broken for most/all
> architecture which are not i386 including x86-64.
> They have FIXADDR_START, but don't need this check and it's even
> wrong to have it.

Ah, Ok.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/