[RFC][Patch] fix for irq_affinity_write_proc v2.5

Keith Mannthey (kmannth@us.ibm.com)
06 May 2003 12:03:08 -0700


Hello,
irq_affinity_write_proc currently directly calls set_ioapic_affinity
which writes to the ioapic. This undermines the work done by kirqd by
writing a cpu mask directly to the ioapic. I propose the following patch
to tie the /proc affinity writes into the same code path as kirqd.
Kirqd will enforce the affinity requested by the user.

Keith Mannthey

diff -urN linux-2.5.68/arch/i386/kernel/irq.c linux-2.5.68-procfix/arch/i386/kernel/irq.c
--- linux-2.5.68/arch/i386/kernel/irq.c Sat Apr 19 19:48:50 2003
+++ linux-2.5.68-procfix/arch/i386/kernel/irq.c Thu May 8 13:47:38 2003
@@ -871,8 +871,11 @@
return -EINVAL;

irq_affinity[irq] = new_value;
- irq_desc[irq].handler->set_affinity(irq, new_value);
-
+ if (irqbalance_disabled)
+ irq_desc[irq].handler->set_affinity(irq, new_value);
+ else
+ do_irq_balance();
+
return full_count;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/