Re: [PATCH[[2.5][6-11] add a new dvb frontend driver

[Christoph Hellwig]

On Tue, May 06, 2003 at 06:13:14PM +0200, Michael Hunold wrote:
> +#include <asm/errno.h>

always use linux/errno.h, not asm/errno.h

> +#include <linux/slab.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +
> +#include "dvb_frontend.h"
> +#include "dvb_functions.h"
> +
> +static int debug = 0;

This is in .bss, no need to initialize.

> +#define dprintk	if (debug) printk

Every heard of do { foo } while (0) ;)

> +static
> +struct dvb_frontend_info cx24110_info = {
> +	name: "Conexant CX24110 with CX24108 tuner, aka HM1221/HM1811",
> +	type: FE_QPSK,

Please use C99 initializers, also the static is positioned very strange..