Re: [PATCH] TTY changes for 2.5.69

Greg KH (greg@kroah.com)
Wed, 7 May 2003 16:16:27 -0700


ChangeSet 1.1100, 2003/05/07 14:59:52-07:00, hannal@us.ibm.com

[PATCH] riscom8 tty_driver add .owner field remove MOD_INC/DEC_USE_COUNT

drivers/char/riscom8.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)

diff -Nru a/drivers/char/riscom8.c b/drivers/char/riscom8.c
--- a/drivers/char/riscom8.c Wed May 7 16:01:09 2003
+++ b/drivers/char/riscom8.c Wed May 7 16:01:09 2003
@@ -552,9 +552,7 @@
wake_up_interruptible(&port->open_wait);
else if (!((port->flags & ASYNC_CALLOUT_ACTIVE) &&
(port->flags & ASYNC_CALLOUT_NOHUP))) {
- MOD_INC_USE_COUNT;
- if (schedule_task(&port->tqueue_hangup) == 0)
- MOD_DEC_USE_COUNT;
+ schedule_task(&port->tqueue_hangup);
}
}

@@ -676,7 +674,6 @@
IRQ_to_board[bp->irq] = bp;
bp->flags |= RC_BOARD_ACTIVE;

- MOD_INC_USE_COUNT;
return 0;
}

@@ -694,7 +691,6 @@
bp->DTR = ~0;
rc_out(bp, RC_DTR, bp->DTR); /* Drop DTR on all ports */

- MOD_DEC_USE_COUNT;
}

/*
@@ -1678,7 +1674,6 @@
tty = port->tty;
if (tty)
tty_hangup(tty); /* FIXME: module removal race still here */
- MOD_DEC_USE_COUNT;
}

static void rc_hangup(struct tty_struct * tty)
@@ -1757,6 +1752,7 @@
memset(IRQ_to_board, 0, sizeof(IRQ_to_board));
memset(&riscom_driver, 0, sizeof(riscom_driver));
riscom_driver.magic = TTY_DRIVER_MAGIC;
+ riscom_driver.owner = THIS_MODULE;
riscom_driver.name = "ttyL";
riscom_driver.major = RISCOM8_NORMAL_MAJOR;
riscom_driver.num = RC_NBOARD * RC_NPORT;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/