Re: PCMCIA 2.5.X sleeping from illegal context

[Andrew Morton]

Alan Cox <[e-mail]> wrote:
>
> On Maw, 2003-05-13 at 00:36, Richard B. Johnson wrote:
> > Could somebody please change the error message? Although everybody
> > seems to want to be a lawyer, even lawyers don't make law. Certainly
> > Software Engineers don't. The correct word is 'invalid', not 'illegal'.
> > Yes, I know there is a 30-year history of the use of that word in
> > Unix, but it's wrong. Only governments make law.
> 
> Much to my suprise you are right on this. The reference dictionary is 
> quite explicit that "illegal" means prohibited by law. Since users will
> eventually see this message it perhaps does make sense to fix it
> 

diff -puN kernel/sched.c~might-sleep-fix kernel/sched.c
--- 25/kernel/sched.c~might-sleep-fix	Tue May 13 16:32:18 2003
+++ 25-akpm/kernel/sched.c	Tue May 13 16:32:46 2003
@@ -2842,8 +2842,8 @@ void __might_sleep(char *file, int line)
 		if (time_before(jiffies, prev_jiffy + HZ))
 			return;
 		prev_jiffy = jiffies;
-		printk(KERN_ERR "Debug: sleeping function called from illegal"
-				" context at %s:%d\n", file, line);
+		printk(KERN_ERR "Debug: sleeping in immoral context "
+					"at %s:%d\n", file, line);
 		dump_stack();
 	}
 #endif

_