Re: 2.5.69-mm4

William Lee Irwin III (wli@holomorphy.com)
Tue, 13 May 2003 17:15:36 -0700


On Mon, May 12, 2003 at 10:55:04PM -0700, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.69/2.5.69-mm4/
> Lots of small things.
> thread-info-in-task_struct.patch
> allow thread_info to be allocated as part of task_struct

AIUI the task_cache is meant to prevent certain task_t (dear gawd I
can't stand those _struct suffixes) refcounting pathologies because
the task_t has its final put done by the task itself or something
on that order, so it may be better for ia64 to adapt the task_cache to
their purposes instead of wiping it entirely. Also, making the
task_cache treatment uniform apart from its declaration would allow the
#ifdef to be shoved in a header.

Alternatively, one could alter the timing of the final put on a task_t
so as to handle it similarly to the final mmput() (though here, too it
might be more sightly to #ifdef the necessary bits in headers).

I think there are already outstanding task_t refcounting bugs, so I'm
not entirely sure where we stand wrt. changing final put mechanics.

-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/