--=_courier-25429-1052915764-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, May 14, 2003 at 10:54:36AM +0100, David Howells wrote:
>=20
> Muli Ben-Yehuda wrote:
>=20
> > > + * VFS session authentication token cache
> > ...
> >
> > If you know the type of the data, why keep it all in one binary blob,
> > instead of a struct? cache effects?=20
>=20
> No. We _don't_ know the type of the data. A filesystem entrusts us with a
> token to keep in the PAG on its behalf. However, since this is meant to b=
e a
> generic mechanism, it's entirely dependent on the fs as to what's in
> the blob.=20
But you do know the type of the data in the blob... it's char* fsname,
const void* key and const void* data, according to your code.=20
You do
void* blob =3D kmalloc(fsname size + key size + data size)
memcpy(blob, fsname, fsname size)
memcpy(blob + fsname offset, key, key size)
mempcy(blob + fsname offset + key offset, data, data size)
I suggest
struct fsblob {=20
const char* fsname;=20
const void* key;=20
size_t keysize;=20
const void* data;=20
size_t datasize;=20
};=20
struct fsblob b;=20
b->fsname =3D kmalloc(fsname size)
memcpy(b->fsname, fsname, fsname size)
etc.=20
Your method loses on additional complexity, and wins on
speed. However, unless it's really, really speed sensitive code, I
would go for KISS any day.
> > Nothing in this patch appears to be using it. You aren't taking a
> > reference to the token here, what's protecting it from disappearing
> > after the return and before the caller gets a chance to do something
> > with it?
>=20
> Thanks. Fixed.
My pleasure.=20
--=20
Muli Ben-Yehuda
http://www.mulix.org
--=_courier-25429-1052915764-0001-2
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE+wjgMKRs727/VN8sRAsVSAJoDC0JFKTEXYk/uJ440GgKVz7EsrQCgmUfy
Hdcrhusf1zb7M5HLmB/uROs=
=Z90Y
-----END PGP SIGNATURE-----
--=_courier-25429-1052915764-0001-2--