Re: RFC Proposal to enable MSI support in Linux kernel

[Greg KH]

Even though you are trying to withdraw this message (which is pointless
for something sent to a mailing list), I had a few small questions with
regards to PCI Hotplug devices:

> +/**
> + * msi_hp_free_vectors: reclaim all MSI previous assigned to this device
> + * argument: device pointer of type struct pci_dev 
> + *
> + * description: used during hotplug removed, from which device is
> hot-removed;

Oops, your patch wrapped, please try another email client, or change the
configuration options of your current one.

> + * PCI subsystem reclaims associated MSI to unused state, which may be used
> 
> + * later on.
> + **/ 
> +void remove_hotplug_vectors(void* dev_id)
> +{
> +     struct msi_desc_t *entry;
> +     struct pci_dev *dev = (struct pci_dev *)dev_id;
> +     int type;
> +     void *mask_entry_addr;
> +      unsigned int flags;

Hm, wierd indenting style, can you just follow Documentation/CodingStyle
and use tabs?

Anyway, what code is supposed to use this function?  A PCI Hotplug
controller driver?  If so, do you have any patches to the current
drivers that show how it is used?

Also, why pass a void *?  That's usually forbidden in the kernel, and
since you are instantly casting it to a struct pci_dev *, why not just
use that?

thanks,

greg k-h