Re: 2.5.69-mm5: CONFIG_ACPI_SLEEP compile error

Pavel Machek (pavel@suse.cz)
Thu, 15 May 2003 16:52:24 +0200


Hi!

> > Mikpe, is this your diff?
> >
> > revision 1.16
> > date: 2003/05/11 18:58:48; author: mikpe; state: Exp; lines: +2 -4
> > restore sysenter MSRs at APM resume
> >
> > I do not know why you changed it (it has certainly nothing to do with
> > APM resume)... Please revert it.
>
> I've just posted a fix for the compile error.
>
> APM suspend and resume now use the save and restore processor state
> procedures in suspend.c. The only alternative is to duplicate that
> functionality in apm.c or a new "suspend-but-not-tied-to-acpi.c" file.
> But suspend.c is fairly generic so it makes sense to share it with APM.
>
> The suspend.c changes are cleanups. The variables are only used in acpi's
> suspend_asm.S and acpi/wakeup.S, so I moved them to suspend_asm.S since
> they aren't needed when suspend is done by APM. fix_processor_context()
> isn't used outside of suspend.c so I made it static.
>
> Do you still have a problem with this?

No, it actually looks better than original. Just make sure it is in
for 2.5.70...
Pavel

-- 
Horseback riding is like software...
...vgf orggre jura vgf serr.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/