Re: qla1280 mem-mapped I/O fix

Andrey Panin (pazke@donpac.ru)
Fri, 16 May 2003 08:06:30 +0400


On 135, 05 15, 2003 at 11:52:45AM -0400, Jes Sorensen wrote:
> >>>>> "Arjan" == Arjan van de Ven <arjanv@redhat.com> writes:
>
> >> @@ -2634,7 +2634,7 @@ /* * Get memory mapped I/O address. */ -
> >> pci_read_config_word (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase); +
> >> pci_read_config_dword (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
> >> mmapbase &= PCI_BASE_ADDRESS_MEM_MASK;
> >>
> >>
> Arjan> shouldn't this be pci_resource_start() ?
>
> Yep,
>
> The existing code is a nightmare, I am working on cleaning this up so
> we can get rid of all the I/O ports crap.

Do you want to convert this driver to use memmaped io only ?

That's bad news for me and visws subarch.

-- 
Andrey Panin		| Embedded systems software developer
pazke@orbita1.ru	| PGP key: wwwkeys.pgp.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/