Re: request_firmware() hotplug interface, third round.

Alan Cox (alan@lxorguk.ukuu.org.uk)
17 May 2003 14:23:32 +0100


> > If the device losses the firmware upon suspend, the driver will have to
> > reinitialize it as if it just got plugged, which somehow makes all
> > devices hotplugable.
>
> So all firmware has to be permanently in RAM anyway?

Of course not you can just go back out to user space and ask for it

> > - In a diskless client, it is the network card

Already insoluble because of routing daemons.

> No, still no good. It means that you get a memory leak if you unload
> a driver before firmware is provided. You need the ability to explicitely
> cancel a request for firmware.

Only if you program it wrongly. Its not exactly hard.

As to an interface. The simplest is probably

request_firmware()
and
request_firmware_nowait(......, workqueuehandler)

The issues brought up about it failing appear bogus too, if the hotplug
run returns a non zero exit code you know about this already.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/