[PATCH] Remove 'strchr' warning from reiserfs

Sam Ravnborg (sam@ravnborg.org)
Sat, 17 May 2003 21:16:11 +0200


Hi Linus, please apply - maintainer cc:ed for info.

Reiserfs emits a warning about strchr being defined but not
used. I finally tracked down the reason for this.
gcc - when seeing strstr(x, "%") recognized that the second parameter
is a char, and therefore uses strchr instead of strstr.
The workaround to avoid the warning is to replace the call
to strstr with strchr - which is OK.

This hides the warning, and brings us down to 6 warnings for a
make defconfig bzImage.

Sam

===== fs/reiserfs/prints.c 1.21 vs edited =====
--- 1.21/fs/reiserfs/prints.c Sun Mar 23 07:14:13 2003
+++ edited/fs/reiserfs/prints.c Sat May 17 21:08:16 2003
@@ -164,7 +164,7 @@

*skip = 0;

- while ((k = strstr (k, "%")) != NULL)
+ while ((k = strchr (k, '%')) != NULL)
{
if (k[1] == 'k' || k[1] == 'K' || k[1] == 'h' || k[1] == 't' ||
k[1] == 'z' || k[1] == 'b' || k[1] == 'y' || k[1] == 'a' ) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/