Re: [PATCH] Added missing dependencies on CRYPTO_HMAC

James Morris (jmorris@intercode.com.au)
Sun, 18 May 2003 13:40:28 +1000 (EST)


On Sun, 18 May 2003, Herbert Xu wrote:

> On Sun, May 18, 2003 at 12:19:09PM +1000, James Morris wrote:
> >
> > See crypto/Kconfig, CRYPTO_HMAC is being defaulted to Y if these protocols
> > are selected.
>
> Yes, but the user can then set them to no. This does happen as the
> Crypto menu is listed after Networking so someone going through it
> in that order can select INET_AH and then go on to disable Crypto.

Yes, we allow users to override the defaults if they wish, at their own
peril.

> Dependencies are there to prevent these things from happening.

Using dependencies would mean that the ipsec protocols would not appear in
the networking menu until after selecting the correct algorthims in the
crypto menu.

How would users know what the minimally required set of algorithms are?
Would they then know to go _back_ to the networking menu to enable the
protocols?

- James

-- 
James Morris
<jmorris@intercode.com.au>

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/