Re: [Linux-ia64] Re: [patch] support 64 bit pci_alloc_consistent

Grant Grundler (iod00d@hp.com)
Sun, 18 May 2003 13:17:18 -0700


On Sun, May 18, 2003 at 12:49:49PM -0500, James Bottomley wrote:
> In that case, the platform returns zero to "this much" being less than
> the full 64 bits implying there's no mask the platform and driver can
> agree on.

My point was it's better if the driver always check the return
value regardless of which interface is ultimately agreed upon.
(in reference to whether "no one cares a flying fish".)

If one accepts that requirement, the only improvement in Arjen's proposal
is the platform DMA support can guess what might be better and make that
the "effective" mask. The driver still needs to check the effective mask.
I happen to agree with davem : redefining this interface in 2.5 for
a trivial improvement doesn't seem reasonable at this point.

a swimming fish,
grant
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/