[PATCH] module owner for ppp_synctty.c

Paul Mackerras (paulus@samba.org)
Mon, 19 May 2003 14:39:56 +1000


This patch fixes ppp_synctty.c (used for doing PPP over some synchronous
serial HDLC links) so that it sets the owner field of the tty line
discipline it exports, rather than using MOD_INC/DEC_USE_COUNT. This
is more or less from Stephen Hemminger.

Please apply.

Thanks,
Paul.

diff -urN linux-2.5/drivers/net/ppp_synctty.c pmac-2.5/drivers/net/ppp_synctty.c
--- linux-2.5/drivers/net/ppp_synctty.c 2003-04-25 09:17:22.000000000 +1000
+++ pmac-2.5/drivers/net/ppp_synctty.c 2003-04-27 17:58:13.000000000 +1000
@@ -202,7 +202,6 @@
struct syncppp *ap;
int err;

- MOD_INC_USE_COUNT;
ap = kmalloc(sizeof(*ap), GFP_KERNEL);
err = -ENOMEM;
if (ap == 0)
@@ -236,7 +235,6 @@
out_free:
kfree(ap);
out:
- MOD_DEC_USE_COUNT;
return err;
}

@@ -276,7 +274,6 @@
if (ap->tpkt != 0)
kfree_skb(ap->tpkt);
kfree(ap);
- MOD_DEC_USE_COUNT;
}

/*
@@ -404,6 +401,7 @@


static struct tty_ldisc ppp_sync_ldisc = {
+ .owner = THIS_MODULE,
.magic = TTY_LDISC_MAGIC,
.name = "pppsync",
.open = ppp_sync_open,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/