Re: Error during compile of 2.5.69-mm8

Thomas Schlichter (schlicht@uni-mannheim.de)
Fri, 23 May 2003 01:28:06 +0200


--Boundary-02=_G0Vz+n87a/VArN2
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: signed data
Content-Disposition: inline

Hi,

On May 23, David S. Miller wrote:
> From: Andrew Morton <akpm@digeo.com>
> Date: Thu, 22 May 2003 16:02:18 -0700
>
> Looks like David converted this macro into a no-op, then moved it into
> netdevice.h.
>
> Problem is, some non-network drivers were using it too.
>
> They shouldn't, it's backwards compatability crap for net drivers
> only. Use explicit ->owner references elsewhere.

Well, as mentioned in my other mail there ARE many occurrences of=20
SET_MODULE_OWNER, for example in the ISDN subtree (just give 'grep' a try).=
=2E.

> Maybe we should put it back the way it was and go edit all the
> netdrivers?
>
> Absolutely not.

Oops, that's what the patch in my other mail does...

> Yoshfuji posted a patch on linux-kernel to fix this already.

Sorry, I must have missed this patch - that would have made my work obsolet=
e -=20
but I'd like to see how that supports all the other SET_MODULE_OWNER calls=
=20
from all the other places...

Best regards
Thomas Schlichter

--Boundary-02=_G0Vz+n87a/VArN2
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+zV0GYAiN+WRIZzQRAsSNAJsEphdyMR9iGKG/tqcLUV5imimHrQCdE2Up
hH7ijIO+JbBc4pUI9RKSQbI=
=cAXo
-----END PGP SIGNATURE-----

--Boundary-02=_G0Vz+n87a/VArN2--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/