Re: [RFC][2.5] generic_usercopy() function (resend, forgot the

David Woodhouse (dwmw2@infradead.org)
Sun, 25 May 2003 12:23:40 +0100


On Fri, 2003-05-23 at 10:47, Christoph Hellwig wrote:
> > + err = func(inode, file, cmd, parg);
> > + if (err == -ENOIOCTLCMD)
> > + err = -EINVAL;
>
> I don't think this is the right place for this substitution - leave it to
> the drivers.

And make it -ENOTTY. -EINVAL is not correct for unknown ioctls.

-- 
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/