Re: [linux-usb-devel] replaced BKL in rio500.c [2.5.69]

Daniele Bellucci (bellucda@tiscali.it)
Sun, 25 May 2003 17:11:20 +0200


..sorry, this one is correct.

--- linux-2.5.69/drivers/usb/misc/rio500.c 2003-05-26
16:23:20.000000000 +0200 +++ linux-2.5.69-new/drivers/usb/misc/rio500.c
2003-05-26 16:24:36.000000000 +0200 @@ -23,6 +23,9 @@
*
* Based upon mouse.c (Brad Keryan) and printer.c (Michael Gee).
*
+ * Changelog:
+ * 25/05/03 replaced lock/unlock_kernel with up/down in open_rio.
+ * Daniele Bellucci (bellucda@tiscali.it)
* */

#include <linux/module.h>
@@ -81,17 +84,17 @@
{
struct rio_usb_data *rio = &rio_instance;

- lock_kernel();
+ down(&(rio->lock));

if (rio->isopen || !rio->present) {
- unlock_kernel();
+ up(&(rio->lock));
return -EBUSY;
}
rio->isopen = 1;

init_waitqueue_head(&rio->wait_q);

- unlock_kernel();
+ up(&(rio->lock));

info("Rio opened.");

-----------------------------------------------------------------------------
-----------------------------------------------------------------------------
--- PGP PKEY
belch76@libero.it">http://pgp.mit.edu:11371/pks/lookup?search=belch76@libero.it&op=index ICQ#
104896040
Netphone/Fax 178.605.7063
Homepage http://web.tiscali.it/bellucda
-----------------------------------------------------------------------------
-----------------------------------------------------------------------------

---

Daniele Bellucci

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/