Re: [PATCH] xirc2ps_cs irq return fix

Alan Cox (alan@lxorguk.ukuu.org.uk)
27 May 2003 11:40:49 +0100


On Maw, 2003-05-27 at 11:45, Andrew Morton wrote:
> The below patch has been in -mm for some time. It was supposed to kill the
> IRQ if 750 of the previous 1000 IRQs weren't handled.
>
> I disabled the killing code because it was triggering on someone's
> works-just-fine setup.
>
> There will be pain involved in getting all this to work right. Do you
> really think there's much value in it?

Being able to at least turn it on at run time is valuable when you are debugging
a box operated by someone who doesnt habitually rebuild kernels. The 750 of 1000
thing doesnt work because it can happen to be timing triggered by blocks of IRQ's
from a chip being folded together. The "million in a row" should be a stuck IRQ,
maybe 50,000 in a row even but just "zillions in a row"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/