Re: [CHECKER] 12 potential leaks in kernel 2.5.69

Pavel Machek (pavel@suse.cz)
Mon, 26 May 2003 11:42:41 +0200


Hi!

linux-2.5.69/drivers/message/i2o/i2o_core.c (lines 1668-1722)
> > [BUG/LEAK: may be false positive; status appears to be leaked elsewhere in
> > the function on purpose]
> >
> > m=i2o_wait_message(c, "AdapterReset");
> > if(m==0xFFFFFFFF)
> > return -ETIMEDOUT;
> > msg=(u32 *)(c->mem_offset+m);
> >
> > Start --->
> > status = pci_alloc_consistent(c->pdev, 4, &status_phys);
> >
> > ... DELETED 48 lines ...
> >
> > {
> > if((jiffies-time) >= 30*HZ)
> > {
> > printk(KERN_ERR "%s: Timeout waiting for IOP reset.\n",
> > c->name);
> > Error --->
> > return -ETIMEDOUT;
> > }
> > schedule();
> > barrier();
>
> Iirc, the above will leak 4 bytes (plus overhead) once per kernel
> boot and controller. This only happens for broken hardware and the
> alternative is memory corruption, depending on how broken the hardware
> is. Wontfix.

Perhaps comment should be added?

-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/