Re: [2.5 patch] let USB_GADGET depend on USB

Adrian Bunk (bunk@fs.tum.de)
Sun, 1 Jun 2003 13:13:03 +0200


On Sat, May 31, 2003 at 04:39:28PM -0700, David Brownell wrote:
> Adrian Bunk wrote:
> >USB_GADGET is still selectable even with USB disabled. It seems the
> >following is intended:
>
> This is wrong.
>
> CONFIG_USB has always represented the master/host side ... while
> CONFIG_USB_GADGET represents just the slave/gadget side.
>
> The two are completely independent. Hardware that supports
> one will typically _not_ support the other. And systems
> that support the slave/gadget side will have no use at all
> for the 100KB+ of "usbcore".
>...

Well, CONFIG_USB_GADGET without CONFIG_USB gives me the following link
error in 2.5.70-mm3:

<-- snip -->

...
LD .tmp_vmlinux1
security/built-in.o(.text+0x246d): In function `find_usb_device':
: undefined reference to `usb_bus_list_lock'
security/built-in.o(.text+0x2481): In function `find_usb_device':
: undefined reference to `usb_bus_list_lock'
security/built-in.o(.text+0x248d): In function `find_usb_device':
: undefined reference to `usb_bus_list'
security/built-in.o(.text+0x2493): In function `find_usb_device':
: undefined reference to `usb_bus_list'
security/built-in.o(.text+0x24b3): In function `find_usb_device':
: undefined reference to `usb_bus_list'
security/built-in.o(.text+0x24ba): In function `find_usb_device':
: undefined reference to `usb_bus_list_lock'
security/built-in.o(.text+0x24c0): In function `find_usb_device':
: undefined reference to `usb_bus_list_lock'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

If you disagree with my patch please fix the compilation of
CONFIG_USB_GADGET without CONFIG_USB.

cu
Adrian

-- 

"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/