Re: [PATCH][2.5] Honour dont_enable_local_apic flag

Brian J. Murrell (brian@interlinx.bc.ca)
01 Jun 2003 13:25:33 -0400


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-21073-1054488428-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2003-06-01 at 07:23, mikpe@csd.uu.se wrote:
>=20
> (And if its local APIC is broken, cpu_has_apic should be cleared
> rather than setting the dont_enable flag. Post-boot code may
> access the local APIC if CONFIG_X86_LOCAL_APIC && cpu_has_apic.)

So would you prefer something more along the lines of:

--- arch/i386/kernel/setup.c.orig 2003-04-26 10:34:35.000000000 -0400
+++ arch/i386/kernel/setup.c 2003-06-01 13:11:47.000000000 -0400
@@ -845,6 +845,10 @@
*/
else if (!memcmp(from, "highmem=3D", 8))
highmem_pages =3D memparse(from+8, &from) >> PAGE_S=
HIFT;
+ else if (!memcmp(from, "nolapic", 7)) {
+ clear_bit(X86_FEATURE_APIC, &boot_cpu_data.=
x86_capability);
+ set_bit(X86_FEATURE_APIC, &disabled_x86_cap=
s);
+ }
nextchar:
c =3D *(from++);
if (!c)

b.

--=20
Brian J. Murrell <brian@interlinx.bc.ca>

--=_courier-21073-1054488428-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA+2jcNl3EQlGLyuXARArOHAKDUcp1cPMeUcZ6/zPMVgMaSFUGv3ACgniYS
9BtNAdj1TQQWj73VLvvIDTo=
=422x
-----END PGP SIGNATURE-----

--=_courier-21073-1054488428-0001-2--