Redundant code?

Stuart MacDonald (stuartm@connecttech.com)
Mon, 2 Jun 2003 11:32:11 -0400


Seems to me the following is redundant code, since get_fd_set also
memsets the fds.res_* bitmaps.

..Stu

--- linux-2.5.70/fs/select.c 2003-05-26 21:00:21.000000000 -0400
+++ linux-2.5.70-new/fs/select.c 2003-06-02 11:40:24.000000000 -0400
@@ -344,9 +344,6 @@
(ret = get_fd_set(n, outp, fds.out)) ||
(ret = get_fd_set(n, exp, fds.ex)))
goto out;
- zero_fd_set(n, fds.res_in);
- zero_fd_set(n, fds.res_out);
- zero_fd_set(n, fds.res_ex);

ret = do_select(n, &fds, &timeout);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/