[CHECKER][PATCH] bw-qcam.c bad copy_to_user

[Hollis Blanchard]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-30764-1054655774-0001-2
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Like radio-cadet.c, bw-qcam.c is calling copy_to_user() where it 
shouldn't. The user buffer is copied to/from kernel space by 
drivers/media/video/videodev.c:video_usercopy() . Please apply.

-- 
Hollis Blanchard
IBM Linux Technology Center

--=_courier-30764-1054655774-0001-2
Content-Type: text/plain; x-unix-mode=0644; name="bwqcam-copy_to_user.txt"; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=bwqcam-copy_to_user.txt

===== drivers/media/video/bw-qcam.c 1.11 vs edited =====
--- 1.11/drivers/media/video/bw-qcam.c	Sun Feb 16 18:16:53 2003
+++ edited/drivers/media/video/bw-qcam.c	Tue Jun  3 10:28:29 2003
@@ -723,8 +723,6 @@
 			/* Good question.. its composite or SVHS so.. */
 			v->type = VIDEO_TYPE_CAMERA;
 			strcpy(v->name, "Camera");
-			if(copy_to_user(arg, &v, sizeof(v)))
-				return -EFAULT;
 			return 0;
 		}
 		case VIDIOCSCHAN:

--=_courier-30764-1054655774-0001-2--