Re: [PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70

Russell King (rmk@arm.linux.org.uk)
Thu, 5 Jun 2003 10:19:36 +0100


On Wed, Jun 04, 2003 at 07:05:47PM -0700, Greg KH wrote:
> diff -Nru a/drivers/pci/bus.c b/drivers/pci/bus.c
> --- a/drivers/pci/bus.c Wed Jun 4 18:11:51 2003
> +++ b/drivers/pci/bus.c Wed Jun 4 18:11:51 2003
> @@ -129,6 +129,5 @@
> }
> }
>
> -EXPORT_SYMBOL(pci_bus_alloc_resource);
> EXPORT_SYMBOL(pci_bus_add_devices);
> EXPORT_SYMBOL(pci_enable_bridges);

Please don't remove this one. Its there for stuff like:

drivers/pcmcia/cardbus.c

struct resource *
cb_alloc_io(unsigned long base, unsigned long num,
unsigned long align, char *name, socket_info_t *s)
{
...
ret = pci_bus_alloc_resource(bridge->bus, res, num, 1,
min, 0, cardbus_adjust, &ca);
}

ie, so cardbus can decently allocate resources from the parent bus.

(Unfortunately there's a huge pile of other changes which the above
cardbus code relies on, and I fear that its getting rather late to
get them into 2.5.)

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/