Re: [PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70

Greg KH (greg@kroah.com)
Thu, 5 Jun 2003 10:04:10 -0700


On Thu, Jun 05, 2003 at 10:19:36AM +0100, Russell King wrote:
> On Wed, Jun 04, 2003 at 07:05:47PM -0700, Greg KH wrote:
> > diff -Nru a/drivers/pci/bus.c b/drivers/pci/bus.c
> > --- a/drivers/pci/bus.c Wed Jun 4 18:11:51 2003
> > +++ b/drivers/pci/bus.c Wed Jun 4 18:11:51 2003
> > @@ -129,6 +129,5 @@
> > }
> > }
> >
> > -EXPORT_SYMBOL(pci_bus_alloc_resource);
> > EXPORT_SYMBOL(pci_bus_add_devices);
> > EXPORT_SYMBOL(pci_enable_bridges);
>
> Please don't remove this one. Its there for stuff like:
>
> drivers/pcmcia/cardbus.c

Sorry, I don't see that in the current kernel version of cardbus.c,
otherwise I would not have moved it out. Feel free to put it back, if
you need it for any future cardbus changes.

Oh, and I was looking at cardbus.c when doing these changes and saw this
old comment:

/*
* This file is going away. Cardbus handling has been re-written to be
* more of a PCI bridge thing, and the PCI code basically does all the
* resource handling. This has wrappers to make the rest of the PCMCIA
* subsystem not notice that it's not here any more.
*
* Linus, Jan 2000
*/

Is that ever going to happen? Just curious, because if so, I can remove
some more functions from pci.h :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/