Re: [patch] fix vlsi_ir.c compile if !CONFIG_PROC_FS

Adrian Bunk (bunk@fs.tum.de)
Sat, 7 Jun 2003 18:13:49 +0200


On Sat, Jun 07, 2003 at 05:58:27PM +0200, Sam Ravnborg wrote:
> On Sat, Jun 07, 2003 at 05:24:34PM +0200, Adrian Bunk wrote:
> > I got the following compile error with !CONFIG_PROC_FS:
> > CC drivers/net/irda/vlsi_ir.o
> > drivers/net/irda/vlsi_ir.c:2047: `PROC_DIR' undeclared (first use in this function)
> > The following patch fixes it:
> >
>
> [snip]
>
> I prefer the following patch:
> Get rid of one ifdef/endif pair.

Yup, I agree, your patch is better.

> Sam
>
> ===== drivers/net/irda/vlsi_ir.c 1.16 vs edited =====
> --- 1.16/drivers/net/irda/vlsi_ir.c Thu Apr 24 14:17:12 2003
> +++ edited/drivers/net/irda/vlsi_ir.c Sat Jun 7 17:55:29 2003
> @@ -1993,9 +1993,7 @@
> #endif
> };
>
> -#ifdef CONFIG_PROC_FS
> #define PROC_DIR ("driver/" DRIVER_NAME)
> -#endif
>
> static int __init vlsi_mod_init(void)
> {

cu
Adrian

-- 

"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/