Re: [PATCH 2/2] xirc2ps_cs update

Jeff Garzik (jgarzik@pobox.com)
Tue, 10 Jun 2003 11:46:55 -0400


On Tue, Jun 10, 2003 at 05:35:18PM +0200, Geller Sandor wrote:
> On Tue, 10 Jun 2003, Daniel Ritz wrote:
>
> > - busy_loop(HZ/25); /* wait 40 msec */
> > + Wait(HZ/25); /* wait 40 msec */
>
> Why not Wait(40); instead Wait(HZ/25) ? Currently HZ is 1000. However, the
> value can change - as it changed from 100 to 1000.

True enough... the best solution is to grep the tree for a
msecs_to_jiffies macro, and use that. Then it will look like

Wait(msecs_to_jiffies(40))

and the macro does the proper scaling versus constant HZ.

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/