Re: [PATCH 1/1] dm: Repair persistent minors

Joe Thornber (thornber@sistina.com)
Wed, 11 Jun 2003 12:59:55 +0100


On Wed, Jun 11, 2003 at 12:19:48PM +0200, Bernd Eckenfels wrote:
> In article <20030611100542.GD2499@fib011235813.fsnet.co.uk> you wrote:
> > Split the dm_create() function into two variants, depending on whether
> > you want the device to have a specific minor number. This avoids
> > the broken overloading of the minor argument to the old dm_create().
>
> why dont you just call dm_create_with_minor() from dm_create and skip the
> create_aux function?

Because I'm trying to avoid having a special value to the 'minor' arg
to indicate that we can use any minor.

> the create_aux function is pretty badly named, me
> thinks. you sould at least call it dm_create_aux.

I use the dm_ prefix for external functions.

- Joe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/