Re: 2.5.70-bk16: nfs crash

Linus Torvalds (torvalds@transmeta.com)
Thu, 12 Jun 2003 08:49:53 -0700 (PDT)


On Thu, 12 Jun 2003, Dipankar Sarma wrote:
>
> hlist poison patch is broken. list_del_rcu() and hlist_del_rcu()
> *must not* re-initialize the pointers. Maneesh submitted a patch
> earlier today that corrects this -

Sorry, but you're wrong.

If you depend on not re-initializing the pointers, you should not use the
"xxx_del()" function, and you should document it.

This is that the __xxx_del() functions are there for - they won't do the
poisoning. The regular delete functions have historically always poisoned
the pointers - it was only removed a few months ago by Andrew.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/