Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters

Rusty Russell (rusty@rustcorp.com.au)
Mon, 16 Jun 2003 13:55:22 +1000


In message <20030616004957.GA15350@twiddle.net> you write:
> On Mon, Jun 16, 2003 at 10:23:41AM +1000, Rusty Russell wrote:
> > Since Andi reports that even that doesn't work for x86-64, I'd say
> > apply this patch based on his: it's an arbitrary change anyway.
>
> No, Andi located the *real* problem. The compiler was over-aligning
> these objects, which added padding, which broke the array semantics
> you were looking for. The solution is to add an attribute aligned;
> he's sent a patch to Linus already.

Thanks for the explanation. Sorry I missed it.

Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/