Re: [patch] SiS IRQ router 96x detection (2.5.69) ...

Thomas Winischhofer (twini@xfree86.org)
Sun, 22 Jun 2003 03:58:27 +0200


Davide Libenzi wrote:
> I have to admit that I was tempted to let this go through by simply
> ignoring you.

Ouch, this hurts. The lawyer in me just told me that this is no proper
way to argue. And he means both sides. I think he's right.

Davide, calm down and take a deep breath. Better? :) Alan probably
receives thousands of mails every day and he therefore tends to make it
somewhat very short sometimes. Be happy that he even aswered at all, right?

You got a point, though. The only issue Alan mentioned was the NULL
initialisation.

Let's give Alan another chance to explain (shortly) why he thought your
patch was ugly - would you, Alan?

Point is, this is a serious issue. IRQ routing is nothing that should be
decided over beauty. Alan, you obviously saw the code. Are you perhaps
willing to make a better patch if you're that unsatisfied with the
current one?

Thomas

-- 
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net          http://www.winischhofer.net/
twini AT xfree86 DOT org

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/