Re: [2.5 patch] fix buggy comparison in cpqphp_pci.c
Greg KH (greg@kroah.com)
Mon, 23 Jun 2003 15:19:14 -0700
On Sat, Jun 21, 2003 at 04:21:53PM +0200, Adrian Bunk wrote:
> Hi Greg,
>
> I don't understand the code good enough to be sure my patch is correct,
> but the current code is definitely buggy:
>
> 0xFF is the maximum value for an u8, so tdevice < 0x100 is _always_
> true.
Nice catch, I've applied this.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/