Re: 2.5.73-mm1 falling over in SDET

James Bottomley (James.Bottomley@steeleye.com)
28 Jun 2003 22:28:57 -0500


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-8143-1056857483-0001-2
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit

On Sat, 2003-06-28 at 19:02, Andrew Morton wrote:
> Yes, isplinux_queuecommand() returns non-zero and the scsi generic layer
> cheerfully goes infinitely recursive.

Sigh, certain persons need to be more careful when doing logic
alterations.

Try the attached.

James

--=_courier-8143-1056857483-0001-2
Content-Type: text/plain; name="tmp.diff"; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment; filename=tmp.diff

=3D=3D=3D=3D=3D drivers/scsi/hosts.c 1.79 vs edited =3D=3D=3D=3D=3D
--- 1.79/drivers/scsi/hosts.c Thu Jun 26 22:51:24 2003
+++ edited/drivers/scsi/hosts.c Sat Jun 28 22:14:12 2003
@@ -194,7 +194,7 @@
shost->use_blk_tcq =3D sht->use_blk_tcq;
shost->highmem_io =3D sht->highmem_io;
=20
- if (!sht->max_host_blocked)
+ if (sht->max_host_blocked)
shost->max_host_blocked =3D sht->max_host_blocked;
else
shost->max_host_blocked =3D SCSI_DEFAULT_HOST_BLOCKED;

--=_courier-8143-1056857483-0001-2--