Re: [PATCH 2.5.73] nbd: maintain compatibility with existing nbd

Paul Clements (kernel@steeleye.com)
Sun, 29 Jun 2003 17:04:55 -0400 (EDT)


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-9746-1056920921-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Sun, 29 Jun 2003, Pavel Machek wrote:

> > > [ ... ] In the meantime, the nbd-client tool currently can't correctly set
> > > the size of the device and either that needs to be worked around in the
> > > driver (I'd done that in the original jumbo patch), or the nbd-client
> > > tool needs to be updated (the patch I'd mailed out for nbd-client works
> > > around the sizing issue by re-opening the nbd). To be clear, that's not
> > > something any of the changes that have gone in so far broke nor address.
> > > It's a consequence of how bd_set_size() is called in fs/block_dev.c
> > > do_open().
> >
> > And here's the (tiny) patch for nbd to maintain compatibility with the
> > existing nbd-client tool. Compiled and tested on a couple machines.
> > Please apply.
>
> You are the maintainer, you can go to the linus directly. (I hope
> Linus took that MAINTAINERS patch).

Not yet, I don't think...

> [Aha, if you wanted *Andrew* to apply it... I guess it is better to
> say directly who do you want to take it.]

Well, it's just that Andrew seems particularly willing to help on this,
so that's why I sent to him...

At any rate, Andrew, here's a cleaned up version of the patch... please apply.

Thanks,
Paul

--=_courier-9746-1056920921-0001-2
Content-Type: text/plain; charset=us-ascii; name="nbd_2_5_compat.diff"
Content-Transfer-Encoding: base64
Content-ID: <Pine.LNX.4.10.10306291704550.764@clements.sc.steeleye.com>
Content-Description:
Content-Disposition: attachment; filename="nbd_2_5_compat.diff"

LS0tIGxpbnV4LTIuNS9kcml2ZXJzL2Jsb2NrL25iZC5jLlBSSVNUSU5FCVNh
dCBKdW4gMjggMTI6NTc6MDMgMjAwMw0KKysrIGxpbnV4LTIuNS9kcml2ZXJz
L2Jsb2NrL25iZC5jCVNhdCBKdW4gMjggMTI6NTc6NTQgMjAwMw0KQEAgLTUw
MywxNSArNTAzLDE4IEBADQogCQkJbG8tPmJsa3NpemVfYml0cysrOw0KIAkJ
CXRlbXAgPj49IDE7DQogCQl9DQotCQlsby0+Ynl0ZXNpemUgJj0gfihsby0+
Ymxrc2l6ZS0xKTsgDQorCQlsby0+Ynl0ZXNpemUgJj0gfihsby0+Ymxrc2l6
ZS0xKTsNCisJCWlub2RlLT5pX2JkZXYtPmJkX2lub2RlLT5pX3NpemUgPSBs
by0+Ynl0ZXNpemU7DQogCQlzZXRfY2FwYWNpdHkobG8tPmRpc2ssIGxvLT5i
eXRlc2l6ZSA+PiA5KTsNCiAJCXJldHVybiAwOw0KIAljYXNlIE5CRF9TRVRf
U0laRToNCi0JCWxvLT5ieXRlc2l6ZSA9IGFyZyAmIH4obG8tPmJsa3NpemUt
MSk7IA0KKwkJbG8tPmJ5dGVzaXplID0gYXJnICYgfihsby0+Ymxrc2l6ZS0x
KTsNCisJCWlub2RlLT5pX2JkZXYtPmJkX2lub2RlLT5pX3NpemUgPSBsby0+
Ynl0ZXNpemU7DQogCQlzZXRfY2FwYWNpdHkobG8tPmRpc2ssIGxvLT5ieXRl
c2l6ZSA+PiA5KTsNCiAJCXJldHVybiAwOw0KIAljYXNlIE5CRF9TRVRfU0la
RV9CTE9DS1M6DQogCQlsby0+Ynl0ZXNpemUgPSAoKHU2NCkgYXJnKSA8PCBs
by0+Ymxrc2l6ZV9iaXRzOw0KKwkJaW5vZGUtPmlfYmRldi0+YmRfaW5vZGUt
Pmlfc2l6ZSA9IGxvLT5ieXRlc2l6ZTsNCiAJCXNldF9jYXBhY2l0eShsby0+
ZGlzaywgbG8tPmJ5dGVzaXplID4+IDkpOw0KIAkJcmV0dXJuIDA7DQogCWNh
c2UgTkJEX0RPX0lUOg0K
--=_courier-9746-1056920921-0001-2--