Re: [PATCH] Fix mtdblock / mtdpart / mtdconcat

David Woodhouse (dwmw2@redhat.com)
Mon, 30 Jun 2003 07:08:38 +0100


On Sun, 2003-06-29 at 21:34, Russell King wrote:
> > could you try v1.6 from CVS, which should refrain from pretending to have
> > ecc/oob access functions of none of the subdevices have them, and hence
> > fix the problem you observed.
>
> While looking over the changes between 1.5 and 1.6, I spotted this. You
> may want to fix this change:
>
> - concat->mtd.eccsize != subdev[i]->eccsize) {
> + concat->mtd.eccsize != subdev[i]->eccsize ||
> + !concat->mtd.read_ecc != !concat->mtd.read_ecc ||
> + !concat->mtd.write_ecc != !concat->mtd.write_ecc ||
> + !concat->mtd.read_oob != !concat->mtd.read_oob ||
> + !concat->mtd.write_oob != !concat->mtd.write_oob) {

Hmmm. That'll optimise well :)

But it shouldn't bite you -- aside from that does it actually fix the
problem you'd observed?

-- 
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/