Re: [PATCH] Add SELinux module to 2.5.74-bk1

Stephen Smalley (sds@epoch.ncsc.mil)
03 Jul 2003 14:05:10 -0400


On Thu, 2003-07-03 at 13:51, Jeff Garzik wrote:
> nitpicks:
>
> 1) "selinux" is a poor toplevel directory. We already have the toplevel
> "security" directory, this code should go in there.

Sorry, I bungled the diffstat (forgot -p1), as pointed out by Greg and
Chris.

> 2) stick includes in the standard include/ directory. I would suggest
> include/security (if the headers are general) or
> include/security/selinux.

Even if the headers are private to the SELinux "module"? No other
kernel code uses them.

-- 
Stephen Smalley <sds@epoch.ncsc.mil>
National Security Agency

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/