Re: 2.5.74-mm1

Andrew Morton (akpm@osdl.org)
Fri, 4 Jul 2003 01:27:34 -0700


Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
>

Changing this:

> static inline void bitmap_or(volatile unsigned long *dst, const volatile unsigned long *bitmap1,
> const volatile unsigned long *bitmap2, int bits)
> {
> int k;
>
> for (k = 0; k < BITS_TO_LONGS(bits); ++k)
> dst[k] = bitmap1[k] | bitmap2[k];
> }

to this:

static inline void bitmap_or(unsigned long *dst, unsigned long *bitmap1,
unsigned long *bitmap2, int bits)
{
int k;
int nr = BITS_TO_LONGS(bits);

for (k = 0; k < nr; k++)
dst[k] = bitmap1[k] | bitmap2[k];
}

fixes it up, and looks nicer anyway. Removing the volatiles (what were
they doing there?) did not fix it. The `nr' thing fixed it.

I shall make that change.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/