Re: ->direct_IO API change in current 2.4 BK

[Trond Myklebust]

>>>>> " " == Jeff Garzik <[e-mail]> writes:

     > s/replacing/adding/

Revert ;-)

     > A new ->direct_IO2 hook would be an addition, so you really
     > want to simply add another feature flag.

You missed the point. This is *instead* of ->direct_IO2. It's only
purpose would be to distinguish between the old

 int (*direct_IO)(int, struct inode *, struct kiobuf *, unsigned long, int);

and the new

 int (*direct_IO)(int, struct file *, struct kiobuf *, unsigned long, int);

Cheers,
  Trond