Re: [PATCH] add seq file helpers from 2.5 (fwd)

[Chris Wright]

* Marcelo Tosatti ([e-mail]) wrote:
> +int single_open(struct file *file, int (*show)(struct seq_file *, void*), void *data)
> +{
> +	struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL);
> +	int res = -ENOMEM;
> +
> +	if (op) {
> +		op->start = single_start;
> +		op->next = single_next;
> +		op->stop = single_stop;
> +		op->show = show;
> +		res = seq_open(file, op);

Any reason not to simply allocate static ops struct?  As in:

  static struct seq_operations single_ops = {
  	.start	= single_start;
	.next	= single_next;
	.stop	= single_stop;
	.show	= show;
  };

  int single_open()
  {
  	req = seq_open(file, &single_ops);
	...
  }

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net