Linux-kernel mailing list archive 1997-48,: comment style

# comment style

Albert D. Cahalan (acahalan@cs.uml.edu)
Mon, 1 Dec 1997 01:11:11 -0500 (EST)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Myrdraal: "Re: 2.1.68 brokenness."
- Previous message: Michael Neuffer: "Re: disk_stat[] accounting [WAS: possible bug in ll_rw_blk.c..]"
- Next in thread: Chris Wedgwood: "Re: comment style"
- Reply: Chris Wedgwood: "Re: comment style"
- Reply: Alan Cox: "Re: comment style"
- Reply: Theodore Y. Ts'o: "Re: comment style"
- Reply: david parsons: "Re: comment style"

In the 2.1.68 patch, I notice changes like this:

-// priv->phyOnline = 1;
+/* priv->phyOnline = 1; */

The ISO has decided to make C++ comments legal in C.
This means you should adjust your gcc config, not hack
the nice new-style comments out of the kernel.

Those old-style comments are not good. There was a pre-2.0.32
kernel which didn't compile because of them. It would be nice
to move in the _other_ direction, converting old-style to
new-style as code changes.

The ISO standardizes C, not obsolete gcc config files.

- Next message: Myrdraal: "Re: 2.1.68 brokenness."
- Previous message: Michael Neuffer: "Re: disk_stat[] accounting [WAS: possible bug in ll_rw_blk.c..]"
- Next in thread: Chris Wedgwood: "Re: comment style"
- Reply: Chris Wedgwood: "Re: comment style"
- Reply: Alan Cox: "Re: comment style"
- Reply: Theodore Y. Ts'o: "Re: comment style"
- Reply: david parsons: "Re: comment style"