Re: parport_ieee1284 compile problem with 2.1.68 on ix68

Rogier Wolff (R.E.Wolff@BitWizard.nl)
Mon, 1 Dec 1997 13:53:54 +0100 (MET)


Andreas Jaeger wrote:
>
> Is this patch for parport_ieee1284 in patch 2.1.68 really correct?
> - if (need_resched)
> + if (resched_needed())

It is "better". This means that IF it can be implemented with a simple
variable, then a simple define

#define resched_needed() need_resched

will do. However if the implementation becomes more complicated, then
it becomes easier to implement it as an inline function.

Now the patch is probably "wrong" too, because the above define is
not in there anywhere...

Roger.

-- 
** R.E.Wolff@BitWizard.nl ** +31-15-2137555 ** http://www.BitWizard.nl/ **
Florida -- A 39 year old construction worker woke up this morning when a
109-car freight train drove over him. According to the police the man was 
drunk. The man himself claims he slipped while walking the dog. 080897