Re: memory leak detector, 2.0.32, patch

Chris Adams (cadams@ro.com)
Wed, 3 Dec 1997 03:09:24 -0600 (CST)


Once upon a time, Ingo Molnar wrote
> oops, does the attached patch fix the problem? 64M and smaller systems
> should work just fine, even without this patch.

Thanks, I'll try it in the morning.

By the way, I noticed arch/i386/kernel/traps.c also defines
VMALLOC_OFFSET. It looks like it should only be a problem if you get an
oops with modules loaded and the call trace passes through a module
routine, and then the problem would be that the kernel has the wrong
idea about module addresses to print. Shouldn't traps.c just include
asm/pgtable.h instead of redefining constants?

-- 
Chris Adams - cadams@ro.com
System Administrator - Renaissance Internet Services
I don't speak for anybody but myself - that's enough trouble.

> --- linux/include/asm-i386/pgtable.h.orig Wed Dec 3 11:45:21 1997 > +++ linux/include/asm-i386/pgtable.h Wed Dec 3 11:46:09 1997 > @@ -193,7 +193,7 @@ > * The vmalloc() routines leaves a hole of 4kB between each vmalloced > * area for the same reason. ;) > */ > -#define VMALLOC_OFFSET (8*1024*1024) > +#define VMALLOC_OFFSET (128*1024*1024) > #define VMALLOC_START ((high_memory + VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)) > #define VMALLOC_VMADDR(x) (TASK_SIZE + (unsigned long)(x))