Re: quick bug-fix for ide-dma.c

mlord (mlord@pobox.com)
Wed, 03 Dec 1997 12:04:50 -0500


C. Scott Ananian wrote:
>
> Someone swapped & and && in ide-dma.c:

Thanks again, but found-it already -- Linus has a patch for 2.1.71

(harmless but annoying bug).

>
> --- linux/drivers/block/ide-dma.c~ Mon Dec 1 21:08:44 1997
> +++ linux/drivers/block/ide-dma.c Wed Dec 3 00:04:00 1997
> @@ -599,7 +599,7 @@
> * Check for Bus-Master DMA capability
> */
> if (!(pcicmd & 4) || !(bmiba = ide_get_or_set_bmiba(bus, fn, d->name))) {
> - if ((ccode >> 16) == PCI_CLASS_STORAGE_RAID || (ccode && 0x8000))
> + if ((ccode >> 16) == PCI_CLASS_STORAGE_RAID || (ccode & 0x8000))
> printk("%s: Bus-Master DMA is disabled (BIOS)\n", d->name);
> }
> ide_setup_pci_device(bus, fn, bmiba, d);

-- 
mlord@pobox.com
The Linux IDE guy