Re: Examine route.c! -- two bugs fixed -- patch attached!
Wolfgang Walter (wolfgang.walter@stusta.mhn.de)
Fri, 5 Dec 1997 01:19:18 +0100
On Thu, Dec 04, 1997 at 11:58:02PM +0100, Daniel Ryde wrote:
> On Thu, 4 Dec 1997, Ingo Molnar wrote:
>
> > i've sent this small route.c patch to Daniel that made every new route
> > RTF_NOTCACHED:
> [snip]
> > but it made no difference, still leak. Does this mean the route cache is
> > innocent?
>
> Umm, that patch actually made the problem even worse. Now I don't need to
> push it. It just leaks continiously, whithout the 'nc' thing.
>
Yes, I would expect exactly that. I really would change ip_rt_put() in
net/route.h to the version in route.c, or, for testing, declare it
extern void ip_rt_put(struct rtable * rt);
in route.h and comment out the inline version.
>
> /Ryde
>
Wolfgang Walter