Linux-kernel mailing list archive 1997-48,: Re: byteorder mess

# Re: byteorder mess

Fare Rideau (rideau@ens.fr)
Fri, 5 Dec 1997 20:46:57 +0100 (MET)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Richard B. Johnson: "Re: novice question -- live kernel debugging?"
- Previous message: Bill Hawes: "Re: 2.1.70: stange NFS modes"

>>: Fare Rideau
>: Alan Cox

>> The only thing wrong with the byteorder patch is long filenames;
>
> Wrong [...] You seem to have broken cross compiling of libc and tools.
> Thats a problem but hardly a big one
>
It's not from my patch: Linus did it. I proposed a fix immediately
after being informed of the bug (I'm not on the linux-kernel list,
so someone had to bounce me the bug-report; hence the delay).

>> Problems: should generic files be included before or after arch-dep #de=
>> fines?
>> If the answer is after, they my patch is just perfect.
>
> The generic include should IMHO include the arch-dep files then define
> the rest
>
I did that once in an old version of my patch. However, that means changing
#include <asm/byteorder.h> into #include <linux/byteorder.h> or such all
over the kernel. *I* for one cannot take such a responsibility: only a major
kernel hacker like Linus or you can do it!

I designed my patch to modify as few files as possible.
User-contributed patches should be concise and understandable
by the maintainer. Hence the long filenames, hence also putting
#include <asm/types.h> in all asm-*/byteorder.h instead of
modifying includer files all over the kernel, as seems be is the
usual policy in Linux. I'm sorry that petty details cause such flamewars.

> Some code uses htonl for initialisers so it has to be constant ;)
>
Correct code, as usually seen in the kernel,
uses __constant_htonl instead.

Regards, and happy kernel hacking!

== Fare' -=- (FR) Franc,ois-Rene' Rideau -=- (VN) DDa(.ng-Vu~ Ba^n ==
CODE, NOT WORDS

- Next message: Richard B. Johnson: "Re: novice question -- live kernel debugging?"
- Previous message: Bill Hawes: "Re: 2.1.70: stange NFS modes"